Rendering puzzles

How does this affect performance with scene rendering?

 

There's obviously more texture color lookups, a few more multiplication operations, and more memory used by the textures.

I can't give you a direct comparison. It should be slower, but not by an awful lot. Apart from the ambient lighting there aren't more texture lookups, and that would be an unfair comparison since it's an additionl feature. But yes, the shader calculations are more involved (more dot product, a pow() for the Schlick approximation etc.). My code isn't yet optimized, and some optimizations would actually need changes to the Leadwerks engine:

• the conversion of textures from linear space to gamma can be don eby the GPU using its sRGB sampling. Right now I have to transform the colors using pow(col, 2.2) and back using pow(col, 1/2.2)
  
• I am currently doing the ambient lighting in the materials because I don't know how to pass the required data to the lighting shaders,
  

Very nice. Looks great.

I am currently doing the ambient lighting in the materials because I don't know how to pass the required data to the lighting shaders,

 

Isn't the ambient lighting color just passed as a uniform in the lighting shaders?

directionallight.shader:

uniform vec4 ambientlight;
...
...
sampleoutput = (diffuse * lightcolor + specular) * attenuation + emission + diffuse * ambientlight;

 

Can you not just pass your data in place of the inherent ambientlight uniform?

Are you saying that this statue render is in Leadwerks?!

Can you not just pass your data in place of the inherent ambientlight uniform?

 

I am using spherical harmonics (think Marmoset Skyshop) which have 9 float parameters, so the 4 channels of the ambient color aren't sufficient. Come to think of it: I am currently using just one cubemap, but there could be many in the scene, so the coefficients (and reflection cubemap values) would depend on the object's position. It might be best to keep these calculations in the materials.

Genebris, that question is a great excuse to post yet another screenshot: Of course it is ;-)

 

http://steamcommunity.com/sharedfiles/filedetails/?id=620641512

 

To be fair, no small of this goes towards the texture quality - the status uses a single 4k texture created by the Quixel suite, using one of its smart materials.

This is amazing! Can you make the same shot with your shader and with default. I suppose your base color texture isn't the same as diffuse but still.

That's actually not too easy, because the assets have to be so different. I tried the following: Used a barrel model from Dexsoft's Industrial3 collection and applied a rusted steel texture from gametextures.com (that is available in both classic and PBR variants):

 

Classic

 

http://images.akamai.steamusercontent.com/ugc/318997198276597375/6C91BE3851233BE9365238615B71AC72E1012060/

 

 

and PBR

 

http://images.akamai.steamusercontent.com/ugc/318997198276599144/73A9480C1634DF36C7D0BE8E3DBBAF46143C8179/

I think you should enable specular reflection in the first image to get an accurate comparison. A plain diffuse texture with no normal map or specular reflection is going to look very flat.

Actually I did, but in all those back and forth changes between the two pipelines I must have made a mistake, I created a clean new project and did the "classic" shot again:

 

http://images.akamai.steamusercontent.com/ugc/318997198277429861/AA729F838AEFA16B397DE94A706744F4ED18E51C/

 

But the direct comparison is really difficult. E.g. in this new shot the light intensity is higher (1.2 instead of 0.8) than in the PBR shots to show some highlights.

The shiny metal barrel looks better in the pbr shot but the rust looks better in the classic shot. If you could get the rust to look more dry and gritty on the shiny barrel it would be best of both.

Pretty interesting, anyways. I look forward to seeing what you do with this.

The shiny metal barrel looks better in the pbr shot but the rust looks better in the classic shot. If you could get the rust to look more dry and gritty on the shiny barrel it would be best of both.

Just need to apply roughness map or something like this, I'm sure it will be possible.

Great work!

Great work here, looking forward to see how it progresses.

If possible, can you post the textures used for the red marble and the rusted metal? I would like to see a more direct comparison just using the inherent LE materials and shaders.

Unfortunately I can't post those textures, since these are proprietary ones by gametextures.com. You could get them with a trial account. But I will make some better comparison screenshots soon.