Entity::RemoveHook Access Voilation

[martyj]

In the non-beta branch.

 

When removing a hook on an entity in the Hook's callback, an access violation occurs.

 

When removing a hook on an entity NOT in the hook, everything works as expected.

 

Code:

 

void tempHook(Entity* entity)
{
if (Window::GetCurrent()->KeyHit(Key::J))
{
 entity->RemoveHook(Entity::UpdateWorldHook, tempHook);
}
}

bool App::Start()
{
temp = Model::Box(3, 3, 3);
temp->AddHook(Entity::UpdateWorldHook, tempHook);
return true;
}

[Josh]

Don't do this! It is iterating through the list as it is doing this, and you are messing up the iterator.

[martyj]

I see.

 

Does having an update hook effect performance much? I have an object that I add an update hook on when it gets interacted with, then I hide the object.

 

After x number of seconds, I show the object, and would like to remove the hook as it's no longer needed to check to see if it should show.

 

What would be the best way to do this?

[Josh]

Ah I see.

 

If you aren't doing this with tons of objects it should be fine.

 

The actor class I talk about here could probably handle this. You could just remove the actor from the entity in the function and it should be okay:

http://www.leadwerks.com/werkspace/topic/15235-actor-class-for-c-entity-management/

 

It's not ready to use yet, but it might be a good option in the future.