End Hook On PlayAnimation Gets Called In Begining

[reepblue]

I've uploaded the needed files to replicate this bug. If you press "T", the model will do it's attacking animation but the test function will fire as soon as you press "T", and not after the animation is done. Watch "Done!" pop up in the log in the script editor as soon as the animation starts!

 

 

endhookbug.zip

[Josh]

Here is the correct method to use:

function Script:testend()
	System:Print("Done!")
end

function Script:Draw()
	if window:KeyHit(Key.T) then 
		self.entity:PlayAnimation("attack0",0.03,300,1,"testend")
	end
end

You were actually calling the function and passing the result (nil) as a function parameter.

The function EndAnimation() will always be called if it is present, so you can just do this:

function Script:EndAnimation(sequence)
	System:Print("Done!")
end

function Script:Draw()
	if window:KeyHit(Key.T) then 
		self.entity:PlayAnimation("attack0",0.03,300,1)
	end
end

This is the recommended method.
 

[reepblue]

From the documentation, it makes it like you can call specific functions after each animation. Working now, gotta make some adjustments though.

[Josh]

1 minute ago, reepblue said:

From the documentation, it makes it like you can call specific functions after each animation. Working now, gotta make some adjustments though.

You can! But this is really just there for backwards compatibility. I should probably remove that from the docs and just leave it in silently.

EndAnimation can receive an integer argument for the current sequence.

[reepblue]

Ahh, did not see your edited post. Mind posting that snip on the documentation page then so no one else looks like an idiot?

[Josh]

function Script:EndAnimation(sequence)
	System:Print("Done!")
end

 

[Josh]

I added this into the script template that is used when you create a new script.

[reepblue]

Thanks, should clear things up.

[tipforeveryone]

On 1/29/2018 at 5:25 AM, Josh said:

function Script:EndAnimation(sequence)
	System:Print("Done!")
end

 

This is still not in document, is it unofficial or you forgot to add it ? @Josh

[Josh]

Added now, thank you.