Window::Show() should force closestate to true.

[reepblue]

Fix this so I don't have to hack it. If you're not going to fix this in Leadwerks, definitely apply this in the new engine if you didn't already!

//-----------------------------------------------------------------------------
// Purpose:
//-----------------------------------------------------------------------------
void ConsoleWindow::Update()
{
	//if (m_pWindow->KeyHit(KEY_END) || m_pWindow->Closed()) App::Shutdown();

	if (m_pWindow->Closed())
	{
		m_pWindow->Hide();
	}

	if (m_pWindow->GetHidden()) return;

	....
}

//-----------------------------------------------------------------------------
// Purpose: 
//-----------------------------------------------------------------------------
void WinApp::UpdateConsoleWindow()
{
#if defined (USE_INPUTCOMMANDS) && (LEADWERKS_3_1) // TEMP
	if (m_pConsoleWindow != NULL)
	{
		m_pConsoleWindow->Update();
		if (m_pWindow->KeyHit(Key::Tilde) && m_pConsoleWindow->GetEngineWindow()->GetHidden())
		{
			// HACK: set the window's closestate to false so it stays open.
			m_pConsoleWindow->GetEngineWindow()->closestate = false;
			m_pConsoleWindow->GetEngineWindow()->Show();
		}
	}
#endif
}

 

[Josh]

Closing and hiding are not necessarily the same thing though. You probably want to use events for any kind of advanced window handling.

[reepblue]

Yeah but at-least for Leadwerks 4, there isn't a event polling for the Window class. If you take the line forcing the member to be true, the window would show for a split second before closing again. What I have now works really well, it's just that I'm worried I'll not have a way to implement this in the new engine as the members of most classes are private. 

[Josh]

If anything, I think calling window::Closed() should reset the state, like how MouseHit does.

[reepblue]

3 hours ago, Josh said:

If anything, I think calling window::Closed() should reset the state, like how MouseHit does.

That's weird and not clear. There should be window::Open() then. 

I'll try that, however.

[Josh]

No, I am talking about behavior I could change. Right now, the window has one Closed() state that is set to true forever if the user ever closes it.

[reepblue]

Ah, maybe do window::Close(bool) and have the default be true.