Bug Open File Zip on Lua App Crash.

[Josh]

@YueAny results with this?

[Yue]

 

I have now tested in beta version 0.97 but I still have the same challenge. Testing in Lua.

Here File Zip Created with ZZip.

Ultra.zip


later I do a test with C++

[Josh]

You should try first without encryption, otherwise you are testing multiple things at the same time.

[Yue]

here with the same problem in C++, the c++ test file has no key to encrypt it.

Edit: I put the zip file in the root directory of the project and the editor does not load. 0.97

[Josh]

What is the full file path to the project you are testing this in?

[Yue]

C:\Users\Yue\Documents\Ultra Engine\Projects\CPPTest

[Josh]

Strange.

I just uploaded a new update that removes the folder part of the path and uses ChangeDir() before loading the package. Only the editor is updated.

[Yue]

I can't understand why it doesn't work, I just put a zip file in the project directory and the editor doesn't load.

[Josh]

Let's get lower level with this. Please copy your ultra.zip file to your desktop and run this code:

#include "UltraEngine.h"

using namespace UltraEngine;

int main(int argc, const char* argv[])
{
    WString path = GetPath(PATH_DESKTOP) + "/ultra.zip";

    int errorp = 0;
    auto zipper = zip_open(path.c_str(), ZIP_RDONLY, &errorp);
    if (not zipper)
    {
        Print("Error: Failed to load zip file. Error " + String(errorp));
    }
    else
    {
        Print("OK");
    }

    return 0;
}

 

[Yue]

14 minutes ago, Josh said:

Let's get lower level with this. Please copy your ultra.zip file to your desktop and run this code:

#include "UltraEngine.h"

using namespace UltraEngine;

int main(int argc, const char* argv[])
{
    WString path = GetPath(PATH_DESKTOP) + "/ultra.zip";

    int errorp = 0;
    auto zipper = zip_open(path.c_str(), ZIP_RDONLY, &errorp);
    if (not zipper)
    {
        Print("Error: Failed to load zip file. Error " + String(errorp));
    }
    else
    {
        Print("OK");
    }

    return 0;
}

[Josh]

Please try this:

#include "UltraEngine.h"

using namespace UltraEngine;

ZIP_EXTERN zip_int64_t
zip_source_make_command_bitmap2(zip_source_cmd_t cmd0, ...) {
    zip_int64_t bitmap;
    va_list ap;

    bitmap = ZIP_SOURCE_MAKE_COMMAND_BITMASK(cmd0);
    
    va_start(ap, cmd0);
    for (;;) {
        int cmd = va_arg(ap, int);
        if (cmd < 0) {
            break;
        }
        bitmap |= ZIP_SOURCE_MAKE_COMMAND_BITMASK(cmd);
    }
    va_end(ap);

    return bitmap;
}

int main(int argc, const char* argv[])
{
    /*WString path = GetPath(PATH_DESKTOP) + "/ultra.zip";
    int errorp = 0;
    auto zipper = zip_open(path.c_str(), ZIP_RDONLY, &errorp);
    if (not zipper)
    {
        Print("Error: Failed to load zip file. Error " + String(errorp));
    }
    else
    {
        Print("OK");
    }*/

    Print("1");

    zip_source_make_command_bitmap2(ZIP_SOURCE_SUPPORTS, ZIP_SOURCE_TELL, ZIP_SOURCE_SUPPORTS_REOPEN, -1);
    Print("2");

    zip_source_make_command_bitmap(ZIP_SOURCE_SUPPORTS, ZIP_SOURCE_TELL, ZIP_SOURCE_SUPPORTS_REOPEN, -1);
    Print("3");

    return 0;
}

 

[Yue]

[Josh]

Okay, those two functions are the exact same code. I suspect there is some preprocessor define that doesn't match in the main project and in the static lib. I will try compiling libzip straight into the Ultra source code instead of as a separate static lib.

[Josh]

In the current build, libzip was compiled into the engine from source, not as a static lib. @Yue Please let me know the result when you use the editor with a project that contains a zip file.

[Yue]

Great, it loads the map editor, even if the zip file is in the root directory. 



 

[Yue]

The editor loads already in the lua script project even if the zip file is in the root directory, and the console confirms that the zip file is loaded, both in Ultra Engine Pro and Ultra Engine Lua.

[Yue]

In the code in both C++ and Lua, it still does not work, it keeps returning an error. 

[Josh]

So is the editor working correctly? Can you browse through the contents of the zip file and load files from inside it?

[Yue]

 

 Yes, in the editor it works correctly, before if I had the zip file in the root directory of the project it did not load the editor. By clicking on the zip file I have access to the content of the Ultra.zip file.

[Yue]

Clik on File Zip. 

[Josh]

Okay, I will do a full build this way now.

[Josh]

@Yue The whole engine is updated now. Please let me know the results.

[Yue]

Ultra Engine, Run perfect on Lua Script.

[Josh]

What about C++?

[Yue]

2 minutes ago, Josh said:

What about C++?

 

Run Perfect. 

Note: When the editor is started with Zip files in the root directory, these files cannot be deleted, as they are being used by the editor.