Give #include hack back in shaders.

[shadmar]

Would be great.

[klepto2]

+1

 

It will make life a lot easier. Specially in situation where a lot of different shaders needs same functions and constants. Currently it is damn hard to maintain constant changes between shaders.

[gamecreator]

Josh, give these people what they want.

[Admin]

The reason we don't is because the shader editor would no longer be able to show the line an error occurs on, and it would make dynamic shader reloading impossible.

[klepto2]

Well, i understand why you may focus on other things currently, but both of your points are not truely valid.

 

1. not getting the correct error-line:

Might be a bit harder to implement, but keeping the original and processed code (maybe even with some metadata) a simple diff should already work. You should be able to register if an errorline is in the included part or not and be able to jump into the correct file.

 

2. impossible to reload?

Definetly not impossible, but might be a bit tricky. Short solution: ignore includes for the reload, just track saves for the main shader. I could live with that.

 

[Josh]

After the flags parameter, there is a hidden feature I use for lighting shaders:

Shader* Shader::Load(const std::string& path, const int flags, const std::string& precode)

 

I use it to pass preprocessor defines to the shaders so I don't have to keep a lot of extra versions of them.

[klepto2]

Just as reminder:

You can do something like this in glsl:

 

code with #pragma include:

 

#version 400

uniform sampler2D texture1;
uniform sampler2D texture2;
uniform bool isbackbuffer;
uniform vec2 buffersize;
uniform float currenttime;
uniform float intensity = 2.0;

out vec4 fragData0;

#pragma include "functions.glsl"

void main(void)
{
 vec2 icoord = vec2(gl_FragCoord.xy/buffersize);
 if (isbackbuffer) icoord.y = 1.0 - icoord.y;

 vec4 scene = texture2D(texture1, icoord); // rendered scene
 vec4 blur = texture2D(texture2, icoord); // glowmap
 fragData0 = clamp(scene + (blur*intensity), 0.0, 1.0);
}

 

and the merged code:

 

 

#version 400

uniform sampler2D texture1;
uniform sampler2D texture2;
uniform bool isbackbuffer;
uniform vec2 buffersize;
uniform float currenttime;
uniform float intensity = 2.0;

out vec4 fragData0;

#line 1 'functions.glsl'
//code of functions.glsl
#line 12 0

void main(void)
{
 vec2 icoord = vec2(gl_FragCoord.xy/buffersize);
 if (isbackbuffer) icoord.y = 1.0 - icoord.y;

 vec4 scene = texture2D(texture1, icoord); // rendered scene
 vec4 blur = texture2D(texture2, icoord); // glowmap
 fragData0 = clamp(scene + (blur*intensity), 0.0, 1.0);
}

 

An idea for the auto reloading: maybe you can only scan open shader files if they use the #include statement and reload only these.

[Josh]

Does that pragma line actually work?

[klepto2]

no, you need to parse it and replace it with the '#line ...' part. Unfortunalty the Khronos group ignores the include requests for ages. HLSL can do this out of the box.

 

Sorry if this wasn't clear. I only choosed #pragma because glsl will ignore everything after #pragma if it is not known to the glsl compiler.